New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving into Next.js examples repo? #2

Closed

leerob opened this issue May 26, 2023 · 1 comment · Fixed by vercel/next.js#50394

leerob commented May 26, 2023

Would you be open to moving this into the Next.js examples repo as a PR? (And updating the deps, removing the experimental flag)?

SuttonJack mentioned this issue

Update Vanilla Extract Example vercel/next.js#50394

Merged

Owner

SuttonJack commented May 26, 2023 •

edited

@leerob vercel/next.js#50394

Note that the experimental flag is required at the moment for the VE plugin - see:

Ideally we can work this out in the near future

SuttonJack closed this as completed

leerob pushed a commit to vercel/next.js that referenced this issue


          Update Vanilla Extract Example (#50394)

27655db

### What?
- Adds an updated Vanilla Extract example
- ~~Note that `@vanilla-extract/next-plugin` currently requires
`experimental: { appDir: true }` to be set.~~

### Why?
- The
[documentation](https://nextjs.org/docs/app/building-your-application/styling/css-in-js)
currently links to a [personal
repo](https://github.com/SuttonJack/vanilla-extract-app-dir)
- Closes SuttonJack/vanilla-extract-app-dir#2

<p align="center"><img width="600"
src="https://github.com/vercel/next.js/assets/92991945/eeab322e-e75e-4999-9fe7-39aa15c45c11"
/></p>

-->

hydRAnger pushed a commit to hydRAnger/next.js that referenced this issue


          Update Vanilla Extract Example (vercel#50394)

a90053b

### What?
- Adds an updated Vanilla Extract example
- ~~Note that `@vanilla-extract/next-plugin` currently requires
`experimental: { appDir: true }` to be set.~~

### Why?
- The
[documentation](https://nextjs.org/docs/app/building-your-application/styling/css-in-js)
currently links to a [personal
repo](https://github.com/SuttonJack/vanilla-extract-app-dir)
- Closes SuttonJack/vanilla-extract-app-dir#2

<p align="center"><img width="600"
src="https://github.com/vercel/next.js/assets/92991945/eeab322e-e75e-4999-9fe7-39aa15c45c11"
/></p>

-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment