Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with rollup@2.75.0+ #208

Closed
Mister-Hope opened this issue May 28, 2022 · 3 comments
Closed

Broken with rollup@2.75.0+ #208

Mister-Hope opened this issue May 28, 2022 · 3 comments

Comments

@Mister-Hope
Copy link
Contributor

Mister-Hope commented May 28, 2022

Results of rollup@2.74.1

interface DateDetail {
    year?: number | undefined;
    month?: number | undefined;
    day?: number | undefined;
    hour?: number | undefined;
    minute?: number | undefined;
    second?: number | undefined;
}
interface DateInfo {
    display: string;
    value: Date | undefined;
    detail: DateDetail;
}
declare const getDate: (date: string | Date | undefined, options?: DateOptions) => DateInfo | null;

Result with 2.75.0 and 2.75.1

interface DateInfo {
    display: string;
    value: Date | undefined;
    detail: DateDetail;
}
declare const getDate: (date: string | Date | undefined, options?: DateOptions) => DateInfo | null;

I do not think any reproduction is needed, you can just write some code with

  • type A (referenced by type B)
  • type B (used by code actually)

Any type A is lost here

Any idea? Shall it be rollup issue or the plugin needs to rewrite some lines to compatable with 2.75.0+

sgratzl added a commit to sgratzl/chartjs-chart-boxplot that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-error-bars that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-geo that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-graph-dagre that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-pcp that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-wordcloud that referenced this issue May 28, 2022
sgratzl added a commit to upsetjs/chartjs-chart-venn that referenced this issue May 28, 2022
sgratzl added a commit to sgratzl/chartjs-chart-graph that referenced this issue May 28, 2022
@Swatinem
Copy link
Owner

Looks like fallout from rollup/rollup#4510.
Lots of internal testcases are failing, so there is enough to reproduce this.

@Swatinem
Copy link
Owner

I filed rollup/rollup#4514 upstream since this looks like it is broken there.
Also #211 will construct a bit more code to convince rollup to retain referenced items.

@Swatinem
Copy link
Owner

This was fixed upstream, and should work again with rollup@2.75.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants