Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid packages without types declaration in package.json seem to be ignored #292

Open
2 of 3 tasks
moltar opened this issue Sep 21, 2023 · 0 comments
Open
2 of 3 tasks

Comments

@moltar
Copy link

moltar commented Sep 21, 2023

Checklist

  • I can reproduce this issue when running this plugin on its own.
  • I am running this plugin on .d.ts files generated by TypeScript.
  • This issue is not related to rolling up @types.

I can reproduce this issue when running this plugin on its own.

I did not attempt this, as I believe tsup is not doing anything unusual with rollup-plugin-dts, and mostly just passing config options as-is. But if you want me to try it with raw rollup config, I can.

Please refer to this issue for all of the details and investigation: egoist/tsup#1007

In summary:

A package.json that has no types property declared, will not result in bundling, even when the package is valid and is passing ATTW (Are the Types Wrong) test.

https://www.npmjs.com/package/@changesets/types?activeTab=code

screenshot-20230921T105725-YNfGyaAr@2x
screenshot-20230921T105740-iM14pRpY@2x

Code Snipped

Full repro with code: https://github.com/moltar/tsup-dts-resolve#readme

Error Message

No error message.

But the types are failing to bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant