New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check deny-list in package-add flow #2715

Open

finestructure opened this issue Nov 15, 2023 · 1 comment

Member

finestructure commented Nov 15, 2023

We've had a package being re-added even though it had been recently removed:

SwiftPackageIndex/PackageList#5671

The package-add flow should check the deny-list and avoid generating a PR in this case.

Member Author

finestructure commented Dec 1, 2023

We are actually attempting to remove urls via the deny list but it doesn't seem to be working (at least not in all cases?).

We should probably move to something more maintainable/testable than the jq based filter.

daveverwer mentioned this issue

[Nightly] Updated Packages SwiftPackageIndex/PackageList#5876

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment