Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Dropdown 2nd round #2394

Closed
jdupre81 opened this issue Feb 24, 2023 · 11 comments
Closed

Commit Dropdown 2nd round #2394

jdupre81 opened this issue Feb 24, 2023 · 11 comments

Comments

@jdupre81
Copy link

jdupre81 commented Feb 24, 2023

Based on feedback from the renku meeting on 23 Feb., it has been suggested to Extend the commit message to 2 or more lines in order to read the complete message.

Currently the message is shown in one short line with 3 dots. See screenshot, column 4

Image

@jdupre81
Copy link
Author

here is the edited design with 2 lines for the commit message on viewport width 800 and max. 3 lines (...) for width 550 px

Screenshot 2023-02-24 at 11 22 26

For small viewport devices I will suggest to keep the current layout

Screenshot 2023-02-24 at 11 30 02

@jdupre81
Copy link
Author

Screenshot 2023-02-24 at 13 52 01

Screenshot 2023-02-24 at 13 52 10

@jdupre81
Copy link
Author

Screenshot 2023-02-24 at 13 52 01

@jdupre81
Copy link
Author

image

@jdupre81
Copy link
Author

the slightly difference between the last 2 designs is just the text alignment for the date.

@lorenzo-cavazzi
Copy link
Member

Thank you @jdupre81
A valuable comment from the last Renku meeting.
We can use a fixed-width font (E.G. courier new or similar) for the commit SHA -- it's pretty standard for repository management platforms

@jdupre81
Copy link
Author

jdupre81 commented Mar 1, 2023

oh, that's sth. new for me. But yes, sure, if this is a good solution then just go for it :)

Questions:
Should I change the design in figma with that Font ?..
Do we have decided which design proposal do we want to use?.

@lorenzo-cavazzi
Copy link
Member

Updating the mockups is probably not needed since it's a small change, but I let this to you 🙂

I strongly prefer the 2 lines versions (more seem to waste vertical space). I'm fine with all of them, not sure whether users generally prefer fixed-width columns.

P.S. About the commit SHA, it's not a rule written in stone but you can see the pattern in many places. This is an example from a random page on GitHub, the commit SHA has a monospace font

image

Generally speaking, this applies also to code. Compare the following 2:

  • Normal font

abcd1234

  • Font for code
abcd1234

@ciyer
Copy link
Contributor

ciyer commented Mar 1, 2023

I like the second-to-last one best (commit message on second line, time display aligned as a column). It may also make sense to show the commit message first, since this is often the most useful piece of information. E.g., this from the design proposal from a couple of years ago.:

Image

@jdupre81
Copy link
Author

jdupre81 commented Mar 1, 2023

Final design:

  • SHA with monospace font.
  • UI Team agreed on the commit message on second line and time displayed aligned as a column.

Image

@lorenzo-cavazzi
Copy link
Member

Renku 2.0 doesn't have the same concept of starting from a commit, and we don't need to refine the older interface further.
I'm closing this issue. Feel free to open a new one if you think there are still reasons to consider improvements to the commits dropdown.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants