Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UI routing #2605

Open
leafty opened this issue Jun 19, 2023 · 0 comments · Fixed by #3009
Open

Refactor UI routing #2605

leafty opened this issue Jun 19, 2023 · 0 comments · Fixed by #3009
Assignees
@leafty
Labels
refactoring UI board

Comments

@leafty
Copy link
Member

leafty commented Jun 19, 2023 •
edited

Currently, routing in the UI is done in source files found in various places which makes searching and finding UI components based on the URL difficult to do, e.g. /projects/:projectId/sessions/new goes through index.js > App.js (2 components with <Route>) > project/Project.present.js (2 components with <Route>).

Suggestion

Refactor routing to have it defined from client/src/routes so that finding which components are rendered based on the URL is made easier.
@leafty leafty mentioned this issue Feb 1, 2024
Merged
@lorenzo-cavazzi lorenzo-cavazzi linked a pull request Feb 5, 2024 that will close this issue
refactor(client): update UI routing #3009
Merged
leafty added a commit that referenced this issue Feb 6, 2024
@leafty
refactor(client): update UI routing (#3009)
a814416 
See #2605.

First part of refactoring UI routing:
* Refactor routing to remove the use of the `render` in favor of a child component
* Refactored some components to remove one level of prop drilling and replace the propagation of `location` and `history` to use the hooks from `react-router`
@leafty leafty reopened this Feb 7, 2024
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafty leafty

Labels
refactoring UI board
Projects
Renku UI board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(client): update UI routing SwissDataScienceCenter/renku-ui
2 participants
@leafty @lorenzo-cavazzi