Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local anchors with # in the links #2613

Closed
lorenzo-cavazzi opened this issue Jun 21, 2023 · 1 comment
Closed

Support local anchors with # in the links #2613

lorenzo-cavazzi opened this issue Jun 21, 2023 · 1 comment
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Motivation

Local anchors (linking to local sections with #) don't work in our file preview; the link doesn't contain the local file name, just the first part of the URL and then #local-ref. See this discussion for more context #2573 (comment).

Perhaps we can try to handle it in RenkuMarkdownWithPathTranslation: catching the links starting with # might not be too hard

Proposal

Time frame this to a day; if there are no reasonable progressions after half a day, let's postpone/drop it.

@lorenzo-cavazzi
Copy link
Member Author

There won't be a unified file browser in Renku 2.0.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant