Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protected branches when migrating project #2728

Closed
lorenzo-cavazzi opened this issue Aug 9, 2023 · 1 comment
Closed

Support protected branches when migrating project #2728

lorenzo-cavazzi opened this issue Aug 9, 2023 · 1 comment
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Motivation

We don't fully support protected branches everywhere in the UI, but we should handle better a few cases since renku-core actually supports that case.
Currently, updating a project with protected branches using the "Update" button from the settings page seems to work but actually leaves the user with the same update button.

Proposal

When migrating a project with a protected branch, we should show a warning and a link to a merge request on GitLab.
This should be easy since renku-core return an ad-hoc response in that case containing the field remote_branch.

{
   "result":{
      "docker_migrated":true,
      "errors":[
         
      ],
      "messages":[
         "Updating dockerfile...",
         "Updated dockerfile.",
         "Applying migration m_0009__new_metadata_storage...",
         "Applying migration m_0010__metadata_fixes...",
         "Migrating old namespaces",
         "Fixing activity ids",
         "Rebuilding workflow metadata",
         "Successfully applied 2 migrations."
      ],
      "remote_branch":"renku/autobranch/master/d1fadcfa",
      "template_migrated":false,
      "warnings":[
         
      ],
      "was_migrated":true
   }
}
@lorenzo-cavazzi
Copy link
Member Author

Not relevant anymore for Renku 2.0.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant