Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button hover flicker on files tab #2926

Closed
Panaetius opened this issue Nov 29, 2023 · 6 comments
Closed

button hover flicker on files tab #2926

Panaetius opened this issue Nov 29, 2023 · 6 comments
Labels
bug status/accepted Issue accepted for roadmap/fixing UI board

Comments

@Panaetius
Copy link
Member

image
these buttons flicker when entering the hover from the top. best reproducible when entering with the mouse from the top middle.

tested on the #2854 deployment on firefox

@Panaetius Panaetius added bug status/triage Issue needs to be triaged labels Nov 29, 2023
@leafty
Copy link
Member

leafty commented Nov 30, 2023

I believe this behaviour is due to the tooltip.

@Panaetius
Copy link
Member Author

yes the tooltip itself should have the hover behavior as well to keep it open when hovered

@leafty
Copy link
Member

leafty commented Dec 5, 2023

Some technical detail here: the tooltips should be placed right outside their reference element (as is the case in Bootstrap docs) but in renku-ui they are placed slightly inside. This cause the flickering issue as the tooltip itself "grabs the hover" which makes it disappear thus creating the flicker cycle.

We shall see if updating and/or adjusting some bootstrap variables revert the behaviour back to normal or if we should set an offset (which will be painful to do).

@lorenzo-cavazzi lorenzo-cavazzi added status/accepted Issue accepted for roadmap/fixing UI board and removed status/triage Issue needs to be triaged labels Jan 8, 2024
@lorenzo-cavazzi
Copy link
Member

The unified file browser will soon disappear in Renku 2.0. Since this bug only marginally affects the usability, I suggest closing this issue.
Feel free to open a new one if you think there are still reasons to consider a similar functionality.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
@leafty
Copy link
Member

leafty commented May 28, 2024

This is a big on almost all tooltips though, so should be kept open.

@lorenzo-cavazzi
Copy link
Member

@leafty If this problem affects any 2.0 page, we should make an issue listing exactly where this should be fixed and possibly add a new rule in the coding guidelines from your comment #2926 (comment) if that's what's causing this flickering.
If that only affects 1.0 pages, it doesn't strike me as an important bugfix but, if you think otherwise, please feel free to re-open the issue and assign it to yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status/accepted Issue accepted for roadmap/fixing UI board
Projects
Status: Done
Development

No branches or pull requests

3 participants