Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Url.js and replace it with generatePath from react-router #3052

Open
leafty opened this issue Feb 28, 2024 · 1 comment
Open

Deprecate Url.js and replace it with generatePath from react-router #3052

leafty opened this issue Feb 28, 2024 · 1 comment
Assignees
@leafty
Labels
UI board

Comments

@leafty
Copy link
Member

leafty commented Feb 28, 2024

We don't need to re-invent the wheel to generate paths for the UI, we should use generatePath from react-router.
@leafty leafty added the status/triage Issue needs to be triaged label Feb 28, 2024
@leafty leafty mentioned this issue Mar 21, 2024
Merged
@leafty leafty mentioned this issue Apr 15, 2024
Merged
@leafty leafty removed the status/triage Issue needs to be triaged label May 17, 2024
@leafty leafty mentioned this issue May 21, 2024
Merged
@lorenzo-cavazzi
Copy link
Member

I think we can keep Url.js for the older Renku 1.0 pages and use generatePath for 2.0.
As part of the PR, it would be nice to have a new rule in the coding guidelines mentioning how to compose URLs

@leafty leafty self-assigned this May 29, 2024
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue May 29, 2024
Merged
@leafty leafty mentioned this issue May 29, 2024
Merged
leafty added a commit that referenced this issue May 30, 2024
@leafty
refactor: deprecate Url.js for Renku 2.0 components (#3158)
fd0f0e8 
See #3052.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafty leafty

Labels
UI board
Projects
Renku UI board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leafty @lorenzo-cavazzi