Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify user info storage in README #49

Open
mattmazzola opened this issue Nov 16, 2019 · 0 comments
Open

Clarify user info storage in README #49

mattmazzola opened this issue Nov 16, 2019 · 0 comments

Comments

@mattmazzola
Copy link

I thought there was some confusing wording in the readme about using cookies and localstorage.

cookie in local storage with your user's information

https://github.com/Swizec/useAuth/blame/master/README.md#L126

  1. I didn't think it was possible to store a "cookie in localstorage". You either store info in a cookie or store info in local storage but not a cookie in local storage.

  2. It says "user information". If this is non-secret stuff from the ID token like name I suppose that's ok but as I understood Auth0 was following all the best practices and not storage sensitive / secrete info in localStorage since it could be compromised by 3rd party scripts. Maybe clarify what this user information is so users don't get worried and think this library is risky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant