Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql@16 dropped long-deprecated support for positional arguments #400

Closed
nkahnfr opened this issue Dec 14, 2021 · 1 comment
Closed
Assignees

Comments

@nkahnfr
Copy link

nkahnfr commented Dec 14, 2021

Hello,

As indicated in the title, graphql v16 introduced a breaking change by removing support for positional args in graphql/execute/subscribe functions (graphql/graphql-js#2904).

Do you plan to update DDP-Apollo to support the latest version of GraphQL.js?

It seems quite a straightforward task so I can create a pull request if it helps.
I identified two files to update so far:

Passing an object with named arguments is supported for a long time so there should be no compatibility issue with previous releases of GraphQL.js (I checked v14.0.0 and it's ok).

Thanks for your help.

@Cliffzz Cliffzz self-assigned this Feb 18, 2022
@Cliffzz
Copy link
Member

Cliffzz commented Feb 18, 2022

Thanks for mentioning this, just released a new version so it should work now.

@Cliffzz Cliffzz closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants