Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create URDU.md #3583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ShadBalti
Copy link

@ShadBalti ShadBalti commented Mar 1, 2024

Add Urdu readme translation for our project.
Close #3497

Screenshot:
Screenshot_20240301-185104

@OwlbanGroup
Copy link

Create URDU. md

Copy link
Author

@ShadBalti ShadBalti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve PR

@OwlbanGroup
Copy link

Add Urdu Translation for READme file@Owlbangroup

@OwlbanGroup
Copy link

Create URDU.md #3585

Copy link
Collaborator

@malakada malakada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks so much for taking the time to provide a translation for Urdu!! 😍

@ShadBalti -- I don't speak/read Urdu, so I have some questions about the content if you can help me out. :) I noticed that you left the commit message in English -- would this be common practice for most developers out of Pakistan/India/elsewhere? If so, is there an explanation in Urdu telling the reader that while Urdu may be their primary language that it's customary to write a commit message in English still? If you don't know, I can reach out to some other devs I know in Pakistan at least and ask their opinion.

This PR looks great, but I'd like to ask that you add a few more commits so that it matches what we're looking for with new translations that make it easier for folks to benefit from your work:

If you've never worked with Markdown tables before, here's a helpful guide from Github about it: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-tables, and if you have questions feel free to ping me on the Discord (https://discord.gg/ZtgtthHYUt) in the #github-help channel (I'm malakada on Discord as well!). 😄

Great work over all though and I'm super excited to approve this after you add a link to it!! 🎉

@malakada
Copy link
Collaborator

malakada commented Apr 5, 2024

Hey @OwlbanGroup -- I know this has been sitting for a long time before getting some attention. Are you still interested in this? If so, we'd be very happy to help you get this merged in. :)

@OwlbanGroup
Copy link

Yes I am thank you.

@malakada
Copy link
Collaborator

malakada commented Apr 6, 2024

@OwlbanGroup let's do it then! 🎉

Just need to add a link to your translation in /translations/README.md. I put some helpful links here: #3583 (review)

Do you need help with this?

@OwlbanGroup
Copy link

OwlbanGroup commented Apr 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Urdu Translation for Readme file
3 participants