Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony/config throws deprecation in functional / integration tests in CI #85

Closed
jrushlow opened this issue Apr 1, 2020 · 4 comments
Closed

Comments

@jrushlow
Copy link
Collaborator

jrushlow commented Apr 1, 2020

Since symfony/config 5.1: The signature of method "Symfony\Component\Config\Definition\Builder\NodeDefinition::setDeprecated()" requires 3 arguments: "string $package, string $version, string $message", not defining them is deprecated.

Functional Test: 16x in ResetPasswordRequestRepositoryTest::setUp from SymfonyCasts\Bundle\ResetPassword\Tests\FunctionalTests\Persistence

Integration Test: 2x in ResetPasswordInterfaceAutowireTest::testResetPasswordInterfaceIsAutowiredByContainer from SymfonyCasts\Bundle\ResetPassword\Tests\IntegrationTests

@jrushlow jrushlow added this to To do in In The Future via automation Apr 1, 2020
@jrushlow
Copy link
Collaborator Author

jrushlow commented Apr 1, 2020

This deprecation is indirectly triggered by the DoctrineBundle, see doctrine/DoctrineBundle#1153 and was introduced by the Symfony/Config package. see symfony/symfony#35871

@kbond
Copy link
Contributor

kbond commented Apr 1, 2020

This doc could be useful to help with this: https://symfony.com/doc/master/components/phpunit_bridge.html#making-tests-fail

@weaverryan
Copy link
Contributor

I think we can close this now?

@jrushlow
Copy link
Collaborator Author

jrushlow commented Apr 3, 2020

yup, fixed in PR #87

@jrushlow jrushlow closed this as completed Apr 3, 2020
In The Future automation moved this from To do to Done Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
In The Future
  
Done
Development

No branches or pull requests

3 participants