Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask steps look very confusing and take a lot of space in HTML report #743

Open
RomaSha2010 opened this issue May 5, 2023 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working

Comments

@RomaSha2010
Copy link

I facing an issue that Metamask steps look very confusing and take a lot of space in HTML report.
Is there a way to wrap/combine them in action steps?

Here is how looks initialSetup and acceptAccess functions in HTML report. Just for instance.


1


2


3



They are mixed and because of that I missing project-related steps.

I did Metamask fixture right the same way as in synpress-examples for Playwright.
I've tried to wrap fixture with test.step() but no luck. Just like with wrapping with test.step() Metamask methods directly inside a test.

Currently Metamask-related steps look like a call of Playwright functions. One by one. That is why report looks how it is.
It would be nice to see them as combined steps in HTML report.

For instance step "Metamask wallet initial setup". It will wrap all Playwright steps under the hood related to the initialSetup function. And HTML report will have only one line for that step. I can expand it and see all Playwright actions as it looks right now.

And step "Accept access at Metamask wallet" will wrap all Playwright steps regarding acceptAccess function. And so on.


This will make the tool more user-friendly and facilitate the correct reading of the report.

@RomaSha2010 RomaSha2010 added the bug 🐛 Something isn't working label May 5, 2023
@neuodev neuodev self-assigned this May 5, 2023
@neuodev
Copy link
Contributor

neuodev commented May 5, 2023

Thanks @RomaSha2010 for reporting this issue!

I differently agree with what you just mentioned about grouping related steps into one.

@drptbl Can you please take a look into this?

@neuodev neuodev assigned drptbl and unassigned neuodev May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants