Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix remember multi account #92

Closed

Conversation

Revadike
Copy link
Contributor

@Revadike Revadike commented May 17, 2020

Fixes #88

@Revadike Revadike changed the base branch from master to develop May 17, 2020 17:19
@SzymonLisowiec
Copy link
Owner

This isn't a resolving issue for remember multiple account. Please take a look /src/Http.js just Http class isn't adapted to support multiple cookie jars. Add it will cause conflicts and errors (e.g. "no cookie jar file") in some cases.

@Revadike
Copy link
Contributor Author

This isn't a resolving issue for remember multiple account. Please take a look /src/Http.js just Http class isn't adapted to support multiple cookie jars. Add it will cause conflicts and errors (e.g. "no cookie jar file") in some cases.

I'm confused. Why does it need to support multiple cookie jar? I assume you'll make a new launcher instance for each account. That should be fine, right?

@Revadike Revadike deleted the bugfix-remember-multi-account branch August 31, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rememberLastSession for multiple accounts
2 participants