Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure main.go is updated with schema changes during ftl dev #1451

Closed
Tracked by #1248
worstell opened this issue May 9, 2024 · 5 comments
Closed
Tracked by #1248

ensure main.go is updated with schema changes during ftl dev #1451

worstell opened this issue May 9, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@worstell
Copy link
Collaborator

worstell commented May 9, 2024

it seemed like the build dir main.go wasn't updating on redeploys until quitting and rerunning with ftl dev --recreate. we need to recompile this file whenever we rebuild the schema because it generates based on schema information now

@github-actions github-actions bot added the triage Issue needs triaging label May 9, 2024
@alecthomas alecthomas mentioned this issue May 9, 2024
@deniseli deniseli removed the triage Issue needs triaging label May 9, 2024
@worstell worstell removed their assignment May 15, 2024
@wesbillman wesbillman added the good first issue Good for newcomers label May 15, 2024
@wesbillman
Copy link
Member

@safeer I assigned this one to you since it's in the same area as the code you're looking at to delete the DeployDir during the build phase.

@alecthomas
Copy link
Collaborator

Delete the DeployDir or the build dir? If it's the former, @gak implemented garbage collection of it yesterday. But the latter makes sense.

@safeer
Copy link
Contributor

safeer commented May 16, 2024

@alecthomas is the generated _ftl directory the DeployDir or the build directory? I have a PR up, but I was mistakenly under the impression they were the same 🙃

@alecthomas
Copy link
Collaborator

alecthomas commented May 16, 2024

I was thinking of DeploymentDir, but I think a completely separate concept is cunningly called DeployDir in the context of the build system 😂 - so DeployDir is correct yep, I was just clarifying.

@safeer
Copy link
Contributor

safeer commented May 17, 2024

Fixed by #1500; verified that main.go is updated now on schema changes.

@safeer safeer closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants