Feature/issue 373 improve testing for jupiter #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-1squared
commented
Feb 7, 2022
|
|
||
| public class GuaranteedFieldRealTest extends ScenarioTest<GuaranteedFieldRealTest.RealGiven, GuaranteedFieldRealTest.RealWhen, GuaranteedFieldRealTest.RealThen> { | ||
| @ExtendWith(JGivenReportExtractingExtension.class) |
There was a problem hiding this comment.
probably not necessary, we don't test these with JUnit5
There was a problem hiding this comment.
also, we should probably move those into core at some point
l-1squared
commented
Feb 7, 2022
| } | ||
|
|
||
| @Override | ||
| public String getFailureMessage(int i) { |
There was a problem hiding this comment.
Explain better how these failure message routine came to be
l-1squared
commented
Feb 7, 2022
| @@ -2,5 +2,6 @@ | |||
|
|
|||
| public enum TestFramework { | |||
| JUnit, | |||
| JUnit5, | |||
| TestNG | |||
| } | |||
There was a problem hiding this comment.
add empty line for POSIX conformity
| { TestFramework.JUnit }, | ||
| { TestFramework.TestNG }, | ||
| } ); | ||
| return Arrays.stream(TestFramework.values()) |
There was a problem hiding this comment.
try if TestFramework.values() will work just fine.
There was a problem hiding this comment.
Documentation indicates that this won't be the case
l-1squared
force-pushed
the
feature/Issue-373-Improve-testing-for-jupiter
branch
from
160e5e3
to
3d2fc1c
Compare
fudler
reviewed
Feb 9, 2022
| } | ||
|
|
||
| @Test | ||
| public void a_succeding_JUnit5_test() { |
fudler
reviewed
Feb 9, 2022
|
|
||
| @Test | ||
| @Issue("#25") | ||
| public void test_classes_with_only_ignored_test_result_in_a_valid_report() { |
There was a problem hiding this comment.
Is it somehow possible to give this method some better name? Needed some time to figure out which word groups belong to the same context. Like "test_classes_which_consist_of_only_ignored_tests" or something.
Also update JGiven Framework tests to also test Junit5 Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
JUnit5 offers to use the same class instance over several methods. This however is not in line with the scenario concept of JGiven. The JGivenExtension removes the scenario after the exection of each state, resulting in failure if the next scenario is executed on the same instance Moreover, it is unclear how scenarios that share the same instance react when these methods are executed in parallel. In addition, the JUnit 5 testframework tests were adapted. It turns out that when JUnit5 fails on the class level it returns a successful report model for method but a failure for the class level. Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
l-1squared
force-pushed
the
feature/Issue-373-Improve-testing-for-jupiter
branch
from
3d2fc1c
to
1bc9d4a
Compare
fudler
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.