Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide JGivenStage outside of spring context - for kotlin allopen #395

Open
jangalinski opened this issue Apr 25, 2019 · 2 comments
Open

Comments

@jangalinski
Copy link
Contributor

When using kotlin, all stage classes and functions have to declared open to get JGiven working.

The kotlin compiler plugin "all-open" can do this for you, which is very convenient. But it requires an annotation on class level to work.

The JGivenStage annotation used in jgiven-spring is a solution for this, but what if you do not use spring?

I ended up defining a custom JGivenStage annotation twice in my kotlin projects, so I would like to have a "centralized" solution.

Maybe introducing a jgiven-kotlin module could be a good place for this?

Would you be open for a PR?

@janschaefer
Copy link
Contributor

I am always open for PR :-). The question is whether a whole jgiven-kotlin module is not a bit of an overkill for just a single annotation. How would such an annotation have to look like?

@jangalinski
Copy link
Contributor Author

see #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants