Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ramp up duration for time profiling #233

Open
emily-ygz opened this issue Apr 14, 2021 · 3 comments
Open

Exclude ramp up duration for time profiling #233

emily-ygz opened this issue Apr 14, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@emily-ygz
Copy link

HammerDB v4.1 supports time profiling for all virtual users but the ramp up time is included which is not a steady state, it would be better if we don't count it.

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 14, 2021

Yes, this is a good suggestion. The plan will be to release the current xtprof as part of v4.1 and then consider this and other potential enhancements for v4.2.

From a practical point of view, the virtual users capturing the timings don't know as such the rampup and duration times only the monitor virtual user knows. However all the calculations are done by the monitor virtual user, so it should be possible to discard the datapoints from the rampup time before the calculations are done.

It is also possible to output all datapoints, however this will be a lot of data.

Other areas where time profiling enhancements could be made are in #224 #145 refering to output in JSON format.

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 14, 2021

As additional thought it should be optional whether to discard data points or not. at 4.1 there is one option in the generic.xml file that enables creating a unique logfile or not. There is the potential with time profiling to add an additional GUI/CLI option to configure time profiling.

@emily-ygz
Copy link
Author

These 2 are very good ideas.

  1. Optional to create a unique logfile for time profiling data
  2. add GUI/CLI option, GUI would be great to visualize the latency

@sm-shaw sm-shaw added the enhancement New feature or request label Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants