-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.gitignore too agressive resulting in a broken site #22
Comments
Hey @unn Looks not so bad. The fileadmin folder you normally never commit, so fine here. The only thing I see is public/typo3conf/, where you normally commit the LocalConfiguration.php and perhaps PackageStates.php and AdditionalConfiguration.php. The public/typo3conf/.gitignore is created by DDEV btw which additionally ignores the AdditionalConfiguration.php. Final conclusion: it's not a bad start and you always can adapt the .gitignore to your needs! |
@unn Are you ok with closing this issue or do you still think something has to be changed? |
I think something needs to be changed, not sure exactly what though. With a mind towards the new user experience, deploying directly via git, I would assume that this distro should result in a functional site. It does not. And I can't find great docs on how to unwind the |
Well, deploying directly with git is not option imho as you always have to run |
Welcome to TYPO3 👍
Actually, the current .gitignore exactly reflects which files should be committed and which ones should not.
Unfortunately there is no canonical way to pull in secrets into TYPO3 configuration.
That is wrong.
That basically conflicts with the main .gitignore of this dist. Not sure how this can be resolved @unn Do you have further questions? Then, as Simon already wrote, you're welcome to join Slack, which might allow an easier way of direct communication. |
You shouldn't commit You should commit I argue that this line need to be removed: TYPO3.CMS.BaseDistribution/.gitignore Line 11 in 5a37398
|
As already stated above, there are several ways to not include the secret and environment specific data in LocalConfiguration.php:
I am currently not sure, what the "official recommendation" is, I think that might be a good idea to sort that out and add the information to the official "Installation guide". Apart from that, anything that @helhum says is already pretty much official for me - especially for the topics Composer and base distribution. I generally agree - some things should be made easier for new users - but it is not always to figure out how. The topic deployment is currently underdocumented. I would expect a minimal documentation for that, also in the "Installation Guide". |
There are multiple ways. DDEV tries to set some sane defaults to get a project running out-of-the-box. Once the project is correctly setup I'd suggest to set |
@gilbertsoft thanks for linking this issues. Please, give me hard reasons why i should put LocalConfiguration in git. Please, this is a strong issue for me. I collected 6 daily issues against (#49). The only pro reasons, I know, are:
If there are more - let me know. |
I am new to Typo3 but not to the PHP/CMS world.
I followed the documentation and ran
composer create-project typo3/cms-base-distribution typo3
which produced a nice and tidy typo3 10.1.0 site for me to play around with inddev
.I ran a quick
git init
in the typo3 directory and committed everything.The site works great in
ddev
, however, when I try to move it to a host provider via git repo there are problems. It seems to stem from an overly aggressive.gitignore
that excludes thepublic
directory.My gut says that I need most of these files in the repo. I don't know best practices for which directories and files are safe to commit so that I don't pollute my repo with secrets. And it seems like some paths,
public/fileadmin/
andpublic/index.php
, shouldn't be ignored in the first place.The text was updated successfully, but these errors were encountered: