Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-index pixel unit #68

Open
KatsanKat opened this issue Mar 3, 2023 · 1 comment
Open

Z-index pixel unit #68

KatsanKat opened this issue Mar 3, 2023 · 1 comment

Comments

@KatsanKat
Copy link

Hello !
I noticed from the playground theme that the zIndex values are written in pixel unit :

zIndex: {
0: '0',
1: '1px',
2: '2px',
4: '4px',
6: '6px',
8: '8px',
10: '10px',
12: '12px',
16: '16px',
20: '20px',
24: '24px',
32: '32px',
40: '40px',
44: '44px',
48: '48px',
56: '56px',
64: '64px',
80: '80px',
104: '104px',
140: '140px',
200: '200px',
},

Since the mdn doc specified that z-index only supports integers,
is there a particular reason you choosed to define it with px or is it a mistake ?

@SGAMERyu
Copy link
Contributor

SGAMERyu commented Mar 4, 2023

Hello ! I noticed from the playground theme that the zIndex values are written in pixel unit :

zIndex: {
0: '0',
1: '1px',
2: '2px',
4: '4px',
6: '6px',
8: '8px',
10: '10px',
12: '12px',
16: '16px',
20: '20px',
24: '24px',
32: '32px',
40: '40px',
44: '44px',
48: '48px',
56: '56px',
64: '64px',
80: '80px',
104: '104px',
140: '140px',
200: '200px',
},

Since the mdn doc specified that z-index only supports integers, is there a particular reason you choosed to define it with px or is it a mistake ?

This should be a copy-paste error. I noticed that the value of z-index is the same as the value of space, so it was likely copied by mistake. I made a PR for this. https://github.com/Tahul/pinceau/pull/69/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants