You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When accessing to questions[0].answer (field in both types) the type is string | number.
When accessing to questions[0].textAnswer (field on one type only) the type is unkown
Have a structure with an array of union of objects
Use field.state in jsx
Expected behavior
Not sure if it's a bug or a missing feature, but I'd like a way to know which is the correct type of the array entry and have all the fields typed accordingly.
The form is handling the values right, typescript isn't.
See the MRE for more comments.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
macOS
TanStack Form adapter
react-form
TanStack Form version
v0.19.4
TypeScript version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
I found this problem interesting so I investigated a little. From what I've gathered, the issue revolves around the DeepValue type and happens because of a default typescript behavior with union types:
typeA={a: string;};typeB={b: number;};typeC=boolean;// Getting a value from a union causes some problems and the DeepValue uses this approachtyperesult1=(A|B)["a"];// anytyperesult2=(B|C)["b"];// any
My idea to solve it boils down to creating a new Get type that behaves differently from the default typescript one:
typeGet<T,Kextendsstring/* or keyof T*/>=Textends{[KeyinK]: infer V;} ? V : never;typeresult1=Get<A|B,"a">;// stringtyperesult2=Get<B|C,"b">;// number
Though I created it, I don't fully know how the Get type works because it sometimes behaves strangely, so this solution feels a bit hacky. Look at what I found changing the else clause. It might be a typescript bug.
typeGet<...>=Textends{ ... } ? V : unknown;typeresult1=Get<A|B,"a">;// unknowntyperesult2=Get<B|C,"b">;// unknowntypeGet<...>=Textends{ ... } ? V : undefined;typeresult1=Get<A|B,"a">;// string | undefinedtyperesult2=Get<B|C,"b">;// number | undefinedtypeGet<...>=Textends{ ... } ? V : never;typeresult1=Get<A|B,"a"|"b">;// never
@crutchcorn, if you and the team think it's a good idea to continue with this issue, I would like to create a PR to solve it. Please let me know if I should.
Describe the bug
The library cannot infer the right type of fields in a (probably weird) edge case, when an array is an union type of objects.
Take this as example:
When accessing to
questions[0].answer
(field in both types) the type isstring | number
.When accessing to
questions[0].textAnswer
(field on one type only) the type isunkown
Your minimal, reproducible example
https://stackblitz.com/edit/tanstack-form-ydorgn?file=src%2Findex.tsx%3AL53-L53
Steps to reproduce
Expected behavior
Not sure if it's a bug or a missing feature, but I'd like a way to know which is the correct type of the array entry and have all the fields typed accordingly.
The form is handling the values right, typescript isn't.
See the MRE for more comments.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
macOS
TanStack Form adapter
react-form
TanStack Form version
v0.19.4
TypeScript version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: