chore: Add recommended eslint rules, dedupe parserOptions (#6865)

.eslintrc.cjs

@@ -3,11 +3,13 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   root: true,
+  reportUnusedDisableDirectives: true,
+  ignorePatterns: ['**/build', '**/coverage', '**/dist'],
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint', 'import'],
   extends: [
+    'eslint:recommended',
     'plugin:@cspell/recommended',
-    'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:import/recommended',
     'plugin:import/typescript',
@@ -115,8 +117,12 @@ const config = {
         ],
       },
     ],
+    'no-case-declarations': 'off',
+    'no-empty': 'off',
+    'no-prototype-builtins': 'off',
     'no-redeclare': 'off',
     'no-shadow': 'error',
+    'no-undef': 'off',
     'sort-imports': ['error', { ignoreDeclarationSort: true }],
   },
   overrides: [

examples/angular/basic/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

examples/angular/default-query-function/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

examples/angular/simple/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

examples/solid/basic-graphql-request/.eslintrc.cjs

@@ -0,0 +1,6 @@
+// @ts-check
+
+/** @type {import('eslint').Linter.Config} */
+const config = {}
+
+module.exports = config

examples/solid/basic-typescript/.eslintrc.cjs

@@ -0,0 +1,6 @@
+// @ts-check
+
+/** @type {import('eslint').Linter.Config} */
+const config = {}
+
+module.exports = config

examples/solid/default-query-function/.eslintrc.cjs

@@ -0,0 +1,6 @@
+// @ts-check
+
+/** @type {import('eslint').Linter.Config} */
+const config = {}
+
+module.exports = config

examples/solid/simple/.eslintrc.cjs

@@ -0,0 +1,8 @@
+// @ts-check
+
+/** @type {import('eslint').Linter.Config} */
+const config = {
+  extends: ['plugin:@tanstack/eslint-plugin-query/recommended'],
+}
+
+module.exports = config

examples/solid/simple/tsconfig.json

@@ -21,5 +21,5 @@
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true
   },
-  "include": ["src"]
+  "include": ["src", ".eslintrc.cjs", "vite.config.ts"]
 }

integrations/react-cra4/.eslintrc.cjs

@@ -6,10 +6,6 @@ module.exports = {
     'plugin:react/recommended',
     'plugin:react-hooks/recommended',
   ],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   settings: {
     react: {
       version: 'detect',

integrations/react-cra5/.eslintrc.cjs

@@ -6,10 +6,6 @@ module.exports = {
     'plugin:react/recommended',
     'plugin:react-hooks/recommended',
   ],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   settings: {
     react: {
       version: 'detect',

integrations/react-next/.eslintrc.cjs

@@ -6,10 +6,6 @@ module.exports = {
     'plugin:react/recommended',
     'plugin:react-hooks/recommended',
   ],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   settings: {
     react: {
       version: 'detect',

integrations/react-vite/.eslintrc.cjs

@@ -6,10 +6,6 @@ module.exports = {
     'plugin:react/recommended',
     'plugin:react-hooks/recommended',
   ],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   settings: {
     react: {
       version: 'detect',

packages/angular-query-devtools-experimental/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/angular-query-experimental/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/angular-query-experimental/src/inject-mutation.ts

@@ -65,5 +65,4 @@ export function injectMutation<
   })
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
 function noop() {}

packages/angular-query-experimental/src/util/create-injection-token/create-injection-token.ts

@@ -180,7 +180,6 @@ export function createNoopInjectionToken<
       (options || {}) as CreateProvideFnOptions<() => void, []>,
     ) as CreateInjectionTokenReturn<TReturn, true>[1],
     token,
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
     () => {},
   ] as CreateInjectionTokenReturn<TReturn, true>
 }

packages/codemods/.eslintrc.cjs

@@ -2,10 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   overrides: [
     {
       files: ['**/__testfixtures__/*'],

packages/eslint-plugin-query/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts

@@ -23,7 +23,6 @@ ruleTester.run('exhaustive-deps', rule, {
     },
     {
       name: 'should pass when deps are passed in template literal',
-      // eslint-disable-next-line no-template-curly-in-string
       code: 'useQuery({ queryKey: [`entity/${id}`], queryFn: () => api.getEntity(id) });',
     },
     {
@@ -464,7 +463,6 @@ ruleTester.run('exhaustive-deps', rule, {
           suggestions: [
             {
               messageId: 'fixTo',
-              // eslint-disable-next-line no-template-curly-in-string
               data: { result: '["entity/${id}", id]' },
               output: normalizeIndent`
                 const id = 1;
@@ -489,7 +487,6 @@ ruleTester.run('exhaustive-deps', rule, {
           suggestions: [
             {
               messageId: 'fixTo',
-              // eslint-disable-next-line no-template-curly-in-string
               data: { result: '[`entity/${a}`, b]' },
               output: normalizeIndent`
                 const a = 1;

packages/query-async-storage-persister/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-async-storage-persister/src/index.ts

@@ -100,5 +100,4 @@ export const createAsyncStoragePersister = ({
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
 function noop() {}

packages/query-broadcast-client-experimental/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-core/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-core/src/infiniteQueryObserver.ts

@@ -49,7 +49,6 @@ export class InfiniteQueryObserver<
     fetchOptions: ObserverFetchOptions,
   ) => Promise<InfiniteQueryObserverResult<TData, TError>>
 
-  // eslint-disable-next-line @typescript-eslint/no-useless-constructor
   constructor(
     client: QueryClient,
     options: InfiniteQueryObserverOptions<

packages/query-devtools/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-devtools/src/Devtools.tsx

@@ -1567,7 +1567,6 @@ const QueryDetails = () => {
 
   const handleRefetch = () => {
     const promise = activeQuery()?.fetch()
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
     promise?.catch(() => {})
   }
 
@@ -1581,7 +1580,6 @@ const QueryDetails = () => {
     activeQuery()!.setState({
       status: 'error',
       error,
-      // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
       fetchMeta: {
         ...activeQuery()!.state.fetchMeta,
         __previousQueryOptions,
@@ -1769,7 +1767,6 @@ const QueryDetails = () => {
                 activeQueryVal.setState({
                   data: undefined,
                   status: 'pending',
-                  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
                   fetchMeta: {
                     ...activeQueryVal.state.fetchMeta,
                     __previousQueryOptions,

packages/query-persist-client-core/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-sync-storage-persister/.eslintrc.cjs

@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
-}
+const config = {}
 
 module.exports = config

packages/query-sync-storage-persister/src/index.ts

@@ -109,5 +109,4 @@ function throttle<TArgs extends Array<any>>(
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
 function noop() {}

packages/react-query-devtools/.eslintrc.cjs

@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: true,
-  },
   rules: {
     'react/jsx-key': ['error', { checkFragmentShorthand: true }],
     'react-hooks/exhaustive-deps': 'error',