Skip to content

Commit 95d814a

Browse files
authoredJul 17, 2024··
chore(utils): Ensure consistent declaration style of utility functions and standardize parameters for the sleep method (#7554)
* refactor: Changed parameter names to match those in other sleep utility functions. * refactor: Most utility functions are defined as regular functions, updated this one to match. * fix: formatting
1 parent eb21d1e commit 95d814a

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed
 

‎packages/query-core/src/__tests__/utils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ export function sleep(timeout: number): Promise<void> {
3232
})
3333
}
3434

35-
export const executeMutation = <TVariables>(
35+
export function executeMutation<TVariables>(
3636
queryClient: QueryClient,
3737
options: MutationOptions<any, any, TVariables, any>,
3838
variables: TVariables,
39-
) => {
39+
) {
4040
return queryClient
4141
.getMutationCache()
4242
.build(queryClient, options)

‎packages/query-core/src/utils.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -340,9 +340,9 @@ function hasObjectPrototype(o: any): boolean {
340340
return Object.prototype.toString.call(o) === '[object Object]'
341341
}
342342

343-
export function sleep(ms: number): Promise<void> {
343+
export function sleep(timeout: number): Promise<void> {
344344
return new Promise((resolve) => {
345-
setTimeout(resolve, ms)
345+
setTimeout(resolve, timeout)
346346
})
347347
}
348348

@@ -378,7 +378,7 @@ export function addToStart<T>(items: Array<T>, item: T, max = 0): Array<T> {
378378
export const skipToken = Symbol()
379379
export type SkipToken = typeof skipToken
380380

381-
export const ensureQueryFn = <
381+
export function ensureQueryFn<
382382
TQueryFnData = unknown,
383383
TQueryKey extends QueryKey = QueryKey,
384384
>(
@@ -387,7 +387,7 @@ export const ensureQueryFn = <
387387
queryHash?: string
388388
},
389389
fetchOptions?: FetchOptions<TQueryFnData>,
390-
): QueryFunction<TQueryFnData, TQueryKey> => {
390+
): QueryFunction<TQueryFnData, TQueryKey> {
391391
if (process.env.NODE_ENV !== 'production') {
392392
if (options.queryFn === skipToken) {
393393
console.error(

‎packages/query-persist-client-core/src/__tests__/utils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export function sleep(timeout: number): Promise<void> {
1313
})
1414
}
1515

16-
export const createMockPersister = (): Persister => {
16+
export function createMockPersister(): Persister {
1717
let storedState: PersistedClient | undefined
1818

1919
return {
@@ -30,7 +30,7 @@ export const createMockPersister = (): Persister => {
3030
}
3131
}
3232

33-
export const createSpyPersister = (): Persister => {
33+
export function createSpyPersister(): Persister {
3434
return {
3535
persistClient: vi.fn(),
3636
restoreClient: vi.fn(),

‎packages/react-query/src/__tests__/utils.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ export function renderWithClient(
2222
} as any
2323
}
2424

25-
export const Blink = ({
25+
export function Blink({
2626
duration,
2727
children,
2828
}: {
2929
duration: number
3030
children: React.ReactNode
31-
}) => {
31+
}) {
3232
const [shouldShow, setShouldShow] = React.useState<boolean>(true)
3333

3434
React.useEffect(() => {

‎packages/solid-query/src/__tests__/utils.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ export function queryKey() {
1212
return [`query_${queryKeyCount}`]
1313
}
1414

15-
export const Blink = (
15+
export function Blink(
1616
props: {
1717
duration: number
1818
} & ParentProps,
19-
) => {
19+
) {
2020
const [shouldShow, setShouldShow] = createSignal<boolean>(true)
2121

2222
createEffect(() => {

0 commit comments

Comments
 (0)
Please sign in to comment.