Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add recommended eslint rules, remove duplicate parserOptions #6865

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 10, 2024

eslint:recommended was missing for some reason. This adds it back :)

Since parserOptions are inherited from root, they don't need to be duplicated in each eslint config file.

Enabled reportUnusedDisableDirectives to remove unnecessary usage of // eslint-disable-next-line

plugin:@typescript-eslint/eslint-recommended is already added by plugin:@typescript-eslint/recommended

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Feb 10, 2024 7:22am

Copy link

nx-cloud bot commented Feb 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37d3290. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37d3290:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4220885) 41.82% compared to head (37d3290) 41.82%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6865   +/-   ##
=======================================
  Coverage   41.82%   41.82%           
=======================================
  Files         179      179           
  Lines        7018     7018           
  Branches     1418     1418           
=======================================
  Hits         2935     2935           
  Misses       3720     3720           
  Partials      363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 8cd6441 into main Feb 10, 2024
10 checks passed
@lachlancollins lachlancollins deleted the cleanup-eslint branch February 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants