Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace @ts-ignore with @ts-expect-error #6866

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 10, 2024

Removes a bunch of unnecessary @ts-ignore statements

See here: https://www.totaltypescript.com/concepts/how-to-use-ts-expect-error

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Feb 10, 2024 7:37am

Copy link

nx-cloud bot commented Feb 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c41951. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c41951:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cd6441) 41.82% compared to head (1c41951) 29.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6866       +/-   ##
===========================================
- Coverage   41.82%   29.95%   -11.87%     
===========================================
  Files         179       68      -111     
  Lines        7018     2277     -4741     
  Branches     1418      541      -877     
===========================================
- Hits         2935      682     -2253     
+ Misses       3720     1415     -2305     
+ Partials      363      180      -183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit e105930 into main Feb 10, 2024
10 checks passed
@lachlancollins lachlancollins deleted the remove-ts-ignore branch February 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants