Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace plugin:react/recommended with plugin:react/jsx-runtime #6868

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 10, 2024

Replaced plugin:react/recommended with plugin:react/jsx-runtime

Disables https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md, which causes very annoying (and incorrect) highlighting of all JSX in the React examples

This is compatible with CRA v4 (see https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)

Also needed to set "jsx" to "react-jsx" in tsconfig, but this has no impact on the build output (generated by tsup).

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2024 9:12am

Copy link

nx-cloud bot commented Feb 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc3d5de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Feb 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc3d5de:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b7cc2f) 41.79% compared to head (dc3d5de) 84.69%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6868       +/-   ##
===========================================
+ Coverage   41.79%   84.69%   +42.89%     
===========================================
  Files         178       23      -155     
  Lines        7015      307     -6708     
  Branches     1416       79     -1337     
===========================================
- Hits         2932      260     -2672     
+ Misses       3720       38     -3682     
+ Partials      363        9      -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 9b496bf into main Feb 10, 2024
10 checks passed
@lachlancollins lachlancollins deleted the eslint-plugin-react-jsx-runtime branch February 10, 2024 09:17
@xiaolannuoyi
Copy link

截屏2024-03-16 21 54 33

@lachlancollins
Copy link
Member Author

截屏2024-03-16 21 54 33

Hi @xiaolannuoyi , could you please create an issue with more details about your setup and a repro?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants