-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace plugin:react/recommended with plugin:react/jsx-runtime #6868
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dc3d5de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc3d5de:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6868 +/- ##
===========================================
+ Coverage 41.79% 84.69% +42.89%
===========================================
Files 178 23 -155
Lines 7015 307 -6708
Branches 1416 79 -1337
===========================================
- Hits 2932 260 -2672
+ Misses 3720 38 -3682
+ Partials 363 9 -354 ☔ View full report in Codecov by Sentry. |
Hi @xiaolannuoyi , could you please create an issue with more details about your setup and a repro? |
Replaced
plugin:react/recommended
withplugin:react/jsx-runtime
Disables https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md, which causes very annoying (and incorrect) highlighting of all JSX in the React examples
This is compatible with CRA v4 (see https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
Also needed to set
"jsx"
to"react-jsx"
in tsconfig, but this has no impact on the build output (generated by tsup).