Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query-codemods): unify directory name as name field of package.json #6913

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Feb 17, 2024

I want to unify directory name as nam field of package.json but I couldn't find why error is occurred in workflow https://github.com/TanStack/query/actions/runs/7938657398/job/21677740503?pr=6913

Could maintainers care this please instead of this please?

Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 2:27am

Copy link

nx-cloud bot commented Feb 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2ab96f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Feb 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ab96f0:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link
Contributor Author

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left my intention

@@ -33,7 +33,7 @@ component_management:
- component_id: query-codemods
name: '@tanstack/query-codemods'
paths:
- packages/codemods/**
- packages/query-codemods/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this package have different directory name with name field of package.json. so I matched it

@manudeli manudeli force-pushed the refactor/query-codemod/directory branch from c064f06 to f983c6f Compare February 17, 2024 02:04
@manudeli manudeli marked this pull request as ready for review February 17, 2024 02:27
@TkDodo TkDodo merged commit 137233b into TanStack:main Feb 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants