Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*): add actions/labeler to label automatically to recognize scope of Pull Request easily #6917

Merged
merged 20 commits into from
Mar 4, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Feb 17, 2024

This actions/labeler will label what package scope is on each Pull Request automaticallly. After this Pull Request merged, labeler can know what package scope have been changed by directory
This action is supported by GitHub Actions officially too like actions/setup-node

Example screenshot

image

Expectation

I am expecting each maintainers can recognize each Pull Request's package scope by labels of it more easily.

Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 11:43am

@manudeli manudeli changed the title ci(*): add actions/labeler to label automatically to recognize scope … ci(*): add actions/labeler to label automatically to recognize scope of Pull Request Feb 17, 2024
Copy link

nx-cloud bot commented Feb 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 11b5a50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

@manudeli manudeli changed the title ci(*): add actions/labeler to label automatically to recognize scope of Pull Request ci(*): add actions/labeler to label automatically to recognize scope of Pull Request easily Feb 17, 2024
Copy link

codesandbox-ci bot commented Feb 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11b5a50:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli marked this pull request as ready for review February 17, 2024 10:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Merging #6917 (e7eb914) into main (d572279) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6917   +/-   ##
=======================================
  Coverage   41.29%   41.29%           
=======================================
  Files         180      180           
  Lines        7193     7193           
  Branches     1454     1454           
=======================================
  Hits         2970     2970           
  Misses       3836     3836           
  Partials      387      387           
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 82.29% <ø> (ø)
@tanstack/eslint-plugin-query 85.11% <ø> (ø)
@tanstack/query-async-storage-persister 48.43% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.63% <ø> (ø)
@tanstack/query-devtools 4.09% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 93.07% <ø> (ø)
@tanstack/react-query-devtools 0.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 84.84% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.81% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

Copy link

@fh-nabeel-ahmad fh-nabeel-ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 3, 2024

we already have labels for packages:

Screenshot 2024-03-03 at 10 45 29

will they be re-used ?

@manudeli
Copy link
Contributor Author

manudeli commented Mar 3, 2024

we already have labels for packages:

Screenshot 2024-03-03 at 10 45 29

will they be re-used ?

Oh thanks, I'll update .github/labeler.yml

Copy link
Contributor Author

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TkDodo I updated now

.github/labeler.yml Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
@TkDodo TkDodo merged commit c2946fc into TanStack:main Mar 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants