Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react-query-devtools): add test case for not in process.env.NODE_ENV='development' #6940

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Feb 19, 2024

not In process.env.NODE_ENV='development', ReactDevTools of @tanstack/react-query-devtools should be return null.
so I added test case for it.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 10:04am

Copy link

nx-cloud bot commented Feb 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6263ec7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Feb 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6263ec7:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli marked this pull request as ready for review February 19, 2024 16:37
@codecov-commenter
Copy link

Codecov Report

Merging #6940 (8c92a5b) into main (d572279) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6940      +/-   ##
==========================================
+ Coverage   41.29%   41.33%   +0.04%     
==========================================
  Files         180      180              
  Lines        7193     7193              
  Branches     1454     1454              
==========================================
+ Hits         2970     2973       +3     
+ Misses       3836     3834       -2     
+ Partials      387      386       -1     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 82.29% <ø> (ø)
@tanstack/eslint-plugin-query 85.11% <ø> (ø)
@tanstack/query-async-storage-persister 48.43% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.63% <ø> (ø)
@tanstack/query-devtools 4.09% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 93.07% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (+10.71%) ⬆️
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 84.84% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.81% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli manudeli changed the title test(react-query-devtools): add test case for production mode test(react-query-devtools): add test case for not in process.env.NODE_ENV='development' Feb 25, 2024
@manudeli manudeli changed the title test(react-query-devtools): add test case for not in process.env.NODE_ENV='development' test(react-query-devtools): add test case for not in process.env.NODE_ENV='development' Feb 25, 2024
@manudeli manudeli requested a review from TkDodo February 26, 2024 13:09
@TkDodo TkDodo merged commit be2bf30 into TanStack:main Feb 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants