fix(query-core): make sure accessing one property on a query result in useQueries tracks properties across all observers #7014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In useQueries, property tracking is still performed on each individual observer. However, not all invocations will access the property on all observers. For example:
will only track the
isLoading
property of the first query in the array ifisLoading
is true, because the loop will eagerly abort, and thus the property isn't accessed at all on other observer, which can lead to missing re-renders.This fix adds a callback to
trackProperties
, which will be invoked when we start to track a property on an observer. Then, in useQueries, we can use this callback to track the property manually for all observers.That makes sure that if a property like
isLoading
is accessed on one observer, it is tracked for all of them.fixes #7000