fix(*): infer data type correctly when conditional skipToken is passed to useQueries #7150
+80
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is passed to useQueries
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c5a233:
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5c5a233. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
thank you. Can you please fix the conflicts and also port this fix to the other adapters that have |
gwansikk
changed the title
|
Thank you for the review. I have also applied it to Angular, Solid, Svelte, Vue! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm a huge enthusiast of TanStack-query! 👋
I've fixed the issue. closes: #7035
In my quest for a better solution, I've explored several alternatives, yet this appears to be the best I could come up with. Frankly, I don't find this fix particularly elegant or "cool", so I'm open to suggestions for enhancement.
I've run the test and everything checks out, so I'm sending over this PR.
Thank you!