Skip to content

Commit 4e2dd61

Browse files
lachlancollinslachlancollins
authoredFeb 3, 2024
ci(examples): Test examples in CI (#5324)
* ci(examples): Test examples on CI * Remove test from example * Update svelte examples * Fix missing svelte types
1 parent 88545f5 commit 4e2dd61

File tree

32 files changed

+83
-99
lines changed

32 files changed

+83
-99
lines changed
 

‎.github/workflows/ci.yml

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ concurrency:
1515

1616
env:
1717
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
18-
NX_CLOUD_AUTH_TOKEN: ${{ secrets.NX_CLOUD_AUTH_TOKEN }}
1918

2019
jobs:
2120
test-and-publish:

‎.github/workflows/pr.yml

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ concurrency:
1313

1414
env:
1515
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
16-
NX_CLOUD_AUTH_TOKEN: ${{ secrets.NX_CLOUD_AUTH_TOKEN }}
1716

1817
jobs:
1918
test:

‎.github/workflows/stale-issues.yml

-30
This file was deleted.

‎.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,5 @@ yarn.lock
4646
*.tsbuildinfo
4747

4848
.nx/cache
49+
vite.config.js.timestamp-*
50+
vite.config.ts.timestamp-*

‎examples/svelte/basic/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@rollup/plugin-replace": "^5.0.5",

‎examples/svelte/column-groups/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@rollup/plugin-replace": "^5.0.5",

‎examples/svelte/column-ordering/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@faker-js/faker": "^8.3.1",

‎examples/svelte/column-ordering/src/App.svelte

+11-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,13 @@
66
getSortedRowModel,
77
flexRender,
88
} from '@tanstack/svelte-table'
9-
import type { ColumnDef, TableOptions } from '@tanstack/svelte-table'
9+
import type {
10+
ColumnDef,
11+
ColumnOrderState,
12+
OnChangeFn,
13+
TableOptions,
14+
VisibilityState,
15+
} from '@tanstack/svelte-table'
1016
import { makeData, type Person } from './makeData'
1117
import { faker } from '@faker-js/faker'
1218
import './index.css'
@@ -65,10 +71,10 @@
6571
6672
const data = makeData(5000)
6773
68-
let columnOrder = []
69-
let columnVisibility = {}
74+
let columnOrder: ColumnOrderState = []
75+
let columnVisibility: VisibilityState = {}
7076
71-
const setColumnOrder = updater => {
77+
const setColumnOrder: OnChangeFn<ColumnOrderState> = updater => {
7278
if (updater instanceof Function) {
7379
columnOrder = updater(columnOrder)
7480
} else {
@@ -83,7 +89,7 @@
8389
}))
8490
}
8591
86-
const setColumnVisibility = updater => {
92+
const setColumnVisibility: OnChangeFn<VisibilityState> = updater => {
8793
if (updater instanceof Function) {
8894
columnVisibility = updater(columnVisibility)
8995
} else {

‎examples/svelte/column-pinning/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@faker-js/faker": "^8.3.1",

‎examples/svelte/column-pinning/src/App.svelte

+14-7
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@
66
getSortedRowModel,
77
flexRender,
88
} from '@tanstack/svelte-table'
9-
import type { ColumnDef, TableOptions } from '@tanstack/svelte-table'
9+
import type {
10+
ColumnDef,
11+
ColumnOrderState,
12+
ColumnPinningState,
13+
OnChangeFn,
14+
TableOptions,
15+
VisibilityState,
16+
} from '@tanstack/svelte-table'
1017
import { makeData, type Person } from './makeData'
1118
import { faker } from '@faker-js/faker'
1219
import './index.css'
@@ -67,11 +74,11 @@
6774
6875
let isSplit = false
6976
70-
let columnOrder = []
71-
let columnPinning = {}
72-
let columnVisibility = {}
77+
let columnOrder: ColumnOrderState = []
78+
let columnPinning: ColumnPinningState = {}
79+
let columnVisibility: VisibilityState = {}
7380
74-
const setColumnOrder = updater => {
81+
const setColumnOrder: OnChangeFn<ColumnOrderState> = updater => {
7582
if (updater instanceof Function) {
7683
columnOrder = updater(columnOrder)
7784
} else {
@@ -86,7 +93,7 @@
8693
}))
8794
}
8895
89-
const setColumnPinning = updater => {
96+
const setColumnPinning: OnChangeFn<ColumnPinningState> = updater => {
9097
if (updater instanceof Function) {
9198
columnPinning = updater(columnPinning)
9299
} else {
@@ -101,7 +108,7 @@
101108
}))
102109
}
103110
104-
const setColumnVisibility = updater => {
111+
const setColumnVisibility: OnChangeFn<VisibilityState> = updater => {
105112
if (updater instanceof Function) {
106113
columnVisibility = updater(columnVisibility)
107114
} else {

‎examples/svelte/column-visibility/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@rollup/plugin-replace": "^5.0.5",

‎examples/svelte/column-visibility/src/App.svelte

+8-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66
getSortedRowModel,
77
flexRender,
88
} from '@tanstack/svelte-table'
9-
import type { ColumnDef, TableOptions } from '@tanstack/svelte-table'
9+
import type {
10+
ColumnDef,
11+
OnChangeFn,
12+
TableOptions,
13+
VisibilityState,
14+
} from '@tanstack/svelte-table'
1015
import './index.css'
1116
1217
type Person = {
@@ -97,9 +102,9 @@
97102
},
98103
]
99104
100-
let columnVisibility = {}
105+
let columnVisibility: VisibilityState = {}
101106
102-
const setColumnVisibility = updater => {
107+
const setColumnVisibility: OnChangeFn<VisibilityState> = updater => {
103108
if (updater instanceof Function) {
104109
columnVisibility = updater(columnVisibility)
105110
} else {

‎examples/svelte/sorting/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "vite build",
99
"serve": "vite preview",
10-
"start": "vite",
11-
"check": "svelte-check --tsconfig ./tsconfig.json"
10+
"test:types": "svelte-check --tsconfig ./tsconfig.json"
1211
},
1312
"devDependencies": {
1413
"@faker-js/faker": "^8.3.1",

‎examples/svelte/sorting/src/App.svelte

+13-7
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66
getSortedRowModel,
77
flexRender,
88
} from '@tanstack/svelte-table'
9-
import type { ColumnDef, TableOptions } from '@tanstack/svelte-table'
9+
import type {
10+
ColumnDef,
11+
OnChangeFn,
12+
SortingState,
13+
TableOptions,
14+
} from '@tanstack/svelte-table'
1015
import { makeData, type Person } from './makeData'
1116
import './index.css'
1217
@@ -64,9 +69,9 @@
6469
6570
const data = makeData(100_000)
6671
67-
let sorting = []
72+
let sorting: SortingState = []
6873
69-
const setSorting = updater => {
74+
const setSorting: OnChangeFn<SortingState> = updater => {
7075
if (updater instanceof Function) {
7176
sorting = updater(sorting)
7277
} else {
@@ -131,10 +136,11 @@
131136
header.getContext()
132137
)}
133138
/>
134-
{{
135-
asc: ' 🔼',
136-
desc: ' 🔽',
137-
}[header.column.getIsSorted().toString()] ?? ''}
139+
{#if header.column.getIsSorted().toString() === 'asc'}
140+
🔼
141+
{:else if header.column.getIsSorted().toString() === 'desc'}
142+
🔽
143+
{/if}
138144
</div>
139145
{/if}
140146
</th>

‎examples/vue/basic/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
"version": "0.0.0",
55
"scripts": {
66
"dev": "vite",
7-
"build": "vue-tsc --noEmit && vite build",
8-
"preview": "vite preview"
7+
"build": "vite build",
8+
"preview": "vite preview",
9+
"test:types": "vue-tsc"
910
},
1011
"dependencies": {
1112
"vue": "^3.4.14",

‎examples/vue/column-ordering/package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
"version": "0.0.0",
44
"scripts": {
55
"dev": "vite",
6-
"build": "vue-tsc --noEmit && vite build",
7-
"preview": "vite preview --port 5050",
8-
"typecheck": "vue-tsc --noEmit"
6+
"build": "vite build",
7+
"preview": "vite preview"
98
},
109
"dependencies": {
1110
"@faker-js/faker": "^8.3.1",

‎examples/vue/column-ordering/src/makeData.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const newPerson = (): Person => {
3636
export function makeData(...lens: number[]) {
3737
const makeDataLevel = (depth = 0): Person[] => {
3838
const len = lens[depth]!
39-
return range(len).map((d): Person => {
39+
return range(len).map((): Person => {
4040
return {
4141
...newPerson(),
4242
subRows: lens[depth + 1] ? makeDataLevel(depth + 1) : undefined,

‎examples/vue/column-pinning/package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
"version": "0.0.0",
44
"scripts": {
55
"dev": "vite",
6-
"build": "vue-tsc --noEmit && vite build",
7-
"preview": "vite preview --port 5050",
8-
"typecheck": "vue-tsc --noEmit"
6+
"build": "vite build",
7+
"preview": "vite preview"
98
},
109
"dependencies": {
1110
"@faker-js/faker": "^8.3.1",

‎examples/vue/column-pinning/src/makeData.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const newPerson = (): Person => {
3636
export function makeData(...lens: number[]) {
3737
const makeDataLevel = (depth = 0): Person[] => {
3838
const len = lens[depth]!
39-
return range(len).map((d): Person => {
39+
return range(len).map((): Person => {
4040
return {
4141
...newPerson(),
4242
subRows: lens[depth + 1] ? makeDataLevel(depth + 1) : undefined,

‎examples/vue/pagination-controlled/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
"version": "0.0.0",
55
"scripts": {
66
"dev": "vite",
7-
"build": "vue-tsc --noEmit && vite build",
8-
"preview": "vite preview"
7+
"build": "vite build",
8+
"preview": "vite preview",
9+
"test:types": "vue-tsc"
910
},
1011
"dependencies": {
1112
"@faker-js/faker": "^8.3.1",

‎examples/vue/pagination-controlled/src/App.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@ function setPagination({
7777
return { pageIndex, pageSize }
7878
}
7979
80-
function handleGoToPage(e) {
80+
function handleGoToPage(e: any) {
8181
const page = e.target.value ? Number(e.target.value) - 1 : 0
8282
goToPageNumber.value = page + 1
8383
table.setPageIndex(page)
8484
}
8585
86-
function handlePageSizeChange(e) {
86+
function handlePageSizeChange(e: any) {
8787
table.setPageSize(Number(e.target.value))
8888
}
8989
</script>

‎examples/vue/pagination/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
"version": "0.0.0",
55
"scripts": {
66
"dev": "vite",
7-
"build": "vue-tsc --noEmit && vite build",
8-
"preview": "vite preview"
7+
"build": "vite build",
8+
"preview": "vite preview",
9+
"test:types": "vue-tsc"
910
},
1011
"dependencies": {
1112
"vue": "^3.4.14",

‎examples/vue/pagination/src/App.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ function rerender() {
7676
data.value = defaultData
7777
}
7878
79-
function handleGoToPage(e) {
79+
function handleGoToPage(e: any) {
8080
const page = e.target.value ? Number(e.target.value) - 1 : 0
8181
goToPageNumber.value = page + 1
8282
table.setPageIndex(page)
8383
}
8484
85-
function handlePageSizeChange(e) {
85+
function handlePageSizeChange(e: any) {
8686
table.setPageSize(Number(e.target.value))
8787
}
8888
</script>

‎examples/vue/pagination/src/makeData.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const newPerson = (): Person => {
3636
export function makeData(...lens: number[]) {
3737
const makeDataLevel = (depth = 0): Person[] => {
3838
const len = lens[depth]!
39-
return range(len).map((d): Person => {
39+
return range(len).map((): Person => {
4040
return {
4141
...newPerson(),
4242
subRows: lens[depth + 1] ? makeDataLevel(depth + 1) : undefined,

‎examples/vue/row-selection/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "0.0.0",
55
"scripts": {
66
"dev": "vite",
7-
"build": "vue-tsc --noEmit && vite build",
7+
"build": "vite build",
88
"preview": "vite preview"
99
},
1010
"dependencies": {

0 commit comments

Comments
 (0)