Skip to content

Commit 8e106a9

Browse files
authoredJan 11, 2024
fix: add optional document context for resize listeners (#5003)
1 parent 0899c33 commit 8e106a9

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed
 

‎packages/table-core/src/features/ColumnSizing.ts

+11-11
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ export interface ColumnSizingHeader {
187187
* @link [API Docs](https://tanstack.com/table/v8/docs/api/features/column-sizing#getresizehandler)
188188
* @link [Guide](https://tanstack.com/table/v8/docs/guide/column-sizing)
189189
*/
190-
getResizeHandler: () => (event: unknown) => void
190+
getResizeHandler: (context?: Document) => (event: unknown) => void
191191
/**
192192
* Returns the current size of the header.
193193
* @link [API Docs](https://tanstack.com/table/v8/docs/api/features/column-sizing#getsize)
@@ -319,7 +319,7 @@ export const ColumnSizing: TableFeature = {
319319

320320
return 0
321321
}
322-
header.getResizeHandler = () => {
322+
header.getResizeHandler = (contextDocument = document) => {
323323
const column = table.getColumn(header.column.id)
324324
const canResize = column?.getCanResize()
325325

@@ -411,8 +411,8 @@ export const ColumnSizing: TableFeature = {
411411
const mouseEvents = {
412412
moveHandler: (e: MouseEvent) => onMove(e.clientX),
413413
upHandler: (e: MouseEvent) => {
414-
document.removeEventListener('mousemove', mouseEvents.moveHandler)
415-
document.removeEventListener('mouseup', mouseEvents.upHandler)
414+
contextDocument.removeEventListener('mousemove', mouseEvents.moveHandler)
415+
contextDocument.removeEventListener('mouseup', mouseEvents.upHandler)
416416
onEnd(e.clientX)
417417
},
418418
}
@@ -427,8 +427,8 @@ export const ColumnSizing: TableFeature = {
427427
return false
428428
},
429429
upHandler: (e: TouchEvent) => {
430-
document.removeEventListener('touchmove', touchEvents.moveHandler)
431-
document.removeEventListener('touchend', touchEvents.upHandler)
430+
contextDocument.removeEventListener('touchmove', touchEvents.moveHandler)
431+
contextDocument.removeEventListener('touchend', touchEvents.upHandler)
432432
if (e.cancelable) {
433433
e.preventDefault()
434434
e.stopPropagation()
@@ -442,23 +442,23 @@ export const ColumnSizing: TableFeature = {
442442
: false
443443

444444
if (isTouchStartEvent(e)) {
445-
document.addEventListener(
445+
contextDocument.addEventListener(
446446
'touchmove',
447447
touchEvents.moveHandler,
448448
passiveIfSupported
449449
)
450-
document.addEventListener(
450+
contextDocument.addEventListener(
451451
'touchend',
452452
touchEvents.upHandler,
453453
passiveIfSupported
454454
)
455455
} else {
456-
document.addEventListener(
456+
contextDocument.addEventListener(
457457
'mousemove',
458458
mouseEvents.moveHandler,
459459
passiveIfSupported
460460
)
461-
document.addEventListener(
461+
contextDocument.addEventListener(
462462
'mouseup',
463463
mouseEvents.upHandler,
464464
passiveIfSupported
@@ -493,7 +493,7 @@ export const ColumnSizing: TableFeature = {
493493
defaultState
494494
? getDefaultColumnSizingInfoState()
495495
: table.initialState.columnSizingInfo ??
496-
getDefaultColumnSizingInfoState()
496+
getDefaultColumnSizingInfoState()
497497
)
498498
}
499499
table.getTotalSize = () =>

0 commit comments

Comments
 (0)
Please sign in to comment.