Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: getCanGroup always resolving to true #4843

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

mozzerbob
Copy link
Contributor

Small update to getCanGroup. It would always resolve to true and ignore the rest of the statement.

Fixing issue #4809.

@step2341
Copy link

step2341 commented Dec 4, 2023

@mozzerbob i can see the fix above, im using "@tanstack/react-table": "^8.10.3", and still having this issue. has this fix been released? @KevinVandy i noticed you have this option in your materialTable, how did you get it to work correctly?

@mozzerbob
Copy link
Contributor Author

@mozzerbob i can see the fix above, im using "@tanstack/react-table": "^8.10.3", and still having this issue. has this fix been released? @KevinVandy i noticed you have this option in your materialTable, how did you get it to work correctly?

It never got merged, its waiting for a maintainer approval.

@tannera-cargill
Copy link

Is it possible to get this merged? This function always returns true, even when enableGrouping is false.

Copy link

nx-cloud bot commented Mar 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b33ce23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants