Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a missing guard for 'undefined' in the getFilteredRowModel function. #5555

Merged
merged 1 commit into from
May 14, 2024

Conversation

jjh2613
Copy link
Contributor

@jjh2613 jjh2613 commented May 14, 2024

Hi,

I had a small issue with GlobalFilter while trying to use filter values with the createTable function.
I encountered a problem related to an undefined value in getFilteredRowModel

I found a missing undefined guard in getFilteredRowModel.ts.
There is another guard (with starting semicolon?) in the same function

;(columnFilters ?? []).forEach(d => {

but it was missing in the section I committed.

After committing this change, everything works fine for me now.

P.S. Thanks for the awesome project. I am really enjoying TanStack Table.

@jjh2613 jjh2613 changed the title Add a missing guard for 'undefined' in the getFilteredRowModel function. fix: Add a missing guard for 'undefined' in the getFilteredRowModel function. May 14, 2024
Copy link

nx-cloud bot commented May 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96a50bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@KevinVandy KevinVandy merged commit 5411f1a into TanStack:main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants