Files with ambiguous names crash on extraction : Fixed #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pratikmhatre please run spotless |
Oh, I missed this. I ran it and pushed the changes now. Sorry ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This crash issue is easily reproducible by renaming any file with one of "zip/tar/rar/7z" and clicking on
Extractoption for the same. This is happening because, as per the current code, every file having name ending with one of above is treated as a compressed file andExtractoption is then enabled for it. On clicking theExtractthe code tries to fetch the file name and the code then crashes as there is no filename present except for the extension itself.+ boolean hasFileName = compressedName.contains(".");Issue tracker
Fixes #4146
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck