Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] loading属性支持透传loadingProps定义如delay等属性 #4190

Open
mustars opened this issue May 14, 2024 · 3 comments
Open

[Button] loading属性支持透传loadingProps定义如delay等属性 #4190

mustars opened this issue May 14, 2024 · 3 comments
Labels
easy easy level of difficulties 💪🏻 enhancement New feature or request issueShoot to be published to be published

Comments

@mustars
Copy link

mustars commented May 14, 2024 •
edited by github-actions bot

这个功能解决了什么问题

延时显示loading，不会造成按钮闪烁。

你建议的方案是什么

和移动端一样可以设定:loadingProps="{ delay: 5000 }"

IssueShoot

  • 预估时长: 1
  • 期望完成时间: 2024-05-27 00:00:00 +0000 UTC
  • 开发难度: 低
  • 参与人数: 1
  • 需求对接人: ivringpeng
  • 验收标准: 实现期望改造效果，提 PR 并通过验收无误
  • 备注: 最终激励以实际提交 pull request 并合并为准
@github-actions GitHub Actions
Copy link
Contributor

👋 @mustars，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@uyarn uyarn added 💭 discussion we are discussing 💪🏻 enhancement New feature or request labels May 14, 2024
@uyarn uyarn added issueShoot easy easy level of difficulties and removed 💭 discussion we are discussing labels May 24, 2024
@uyarn uyarn changed the title Button按钮loading属性增加可设定delay值 [Button] Button按钮loading属性支持透传loadingProps May 24, 2024
@uyarn uyarn changed the title [Button] Button按钮loading属性支持透传loadingProps [Button] Button按钮loading属性支持透传loadingProps定义如delay等属性 May 24, 2024
@uyarn uyarn changed the title [Button] Button按钮loading属性支持透传loadingProps定义如delay等属性 [Button] loading属性支持透传loadingProps定义如delay等属性 May 24, 2024
@uyarn uyarn mentioned this issue May 24, 2024
Merged
novlan1 added a commit to novlan1/tdesign-vue-next that referenced this issue May 25, 2024
@novlan1
feat(button): support loadingProps
b226b96 
closed Tencent#4190
@novlan1 novlan1 mentioned this issue May 25, 2024
Merged
16 tasks
@novlan1
Copy link
Contributor

novlan1 commented May 25, 2024 •
edited

loading 组件自身的 delay，在非 slot 模式，也就是 loading 作为独立元素时，delay并不生效，不知道是 feature 还是 bug，文档示例就可以看到。
button 组件使用的是独立模式的 loading，所以 delay 也是不生效的。
image

@uyarn uyarn added the to be published to be published label May 25, 2024
@uyarn uyarn closed this as completed in 23de98d May 25, 2024
@uyarn uyarn reopened this May 25, 2024
@uyarn
Copy link
Collaborator

uyarn commented May 25, 2024

loading 组件自身的 delay，在非 slot 模式，也就是 loading 作为独立元素时，delay并不生效，不知道是 feature 还是 bug，文档示例就可以看到。 button 组件使用的是独立模式的 loading，所以 delay 也是不生效的。 image

这可能得作为另一个问题来处理了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy easy level of difficulties 💪🏻 enhancement New feature or request issueShoot to be published to be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mustars @uyarn @novlan1