Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Glide and Gradle versions #4

Open
Sulfkain opened this issue Apr 25, 2018 · 10 comments
Open

Update Glide and Gradle versions #4

Sulfkain opened this issue Apr 25, 2018 · 10 comments

Comments

@Sulfkain
Copy link

Hello,
I'm trying to use your lib, but the problem is dependencies are really old.
The last version of Glide is 4.7 and you are using 3.8.
With gradle happens the same, you are using 3.2.1 while the last is 4.4.

I'm having collision between your dependencies and mines, because im using 4.5 Glide and you need 3.8.
Gradle shows the error:
Failed to find byte code for com/bumptech/glide/request/target/GlideDrawableImageViewTarget
This class was removed from >=v4 from Glide.

Could you please, update this repo with latest dependencies.

Thanks.

@gwlove
Copy link
Member

gwlove commented Apr 26, 2018 via email

@Sulfkain
Copy link
Author

Perfect!,
Do you know the stimated time? maybe 1 month?, 2? more? less?
Just to know and planning our project.

Thanks you!

@gwlove
Copy link
Member

gwlove commented May 3, 2018 via email

@Sulfkain
Copy link
Author

Any updated about this?

Thanks!

@ctrl-alt-del
Copy link
Contributor

Hi @Sulfkain

Thanks for reaching out to us. We are still working on a few things on the SDK.

In the meantime, I cherry picked the changes that you need and pushed them to a separate updated_libraries branch.

On that branch, Glide is updated to version 4.7.1 and gradle wrapper is updated to version 4.4. You can build yourself a aar out of that branch using ./gradlew assembleRelease, and grab the aar file from build/outputs/aar/tenor-android-core-release.aar.

Free feel to let me know if you have any questions.

@Sulfkain
Copy link
Author

@ctrl-alt-del Thank's!
I will try

@wvmoreira
Copy link

Hello friend, Are you planning to use the v4 do Glide library?

@gwlove
Copy link
Member

gwlove commented Jul 16, 2019

Hello friend, Are you planning to use the v4 do Glide library?

Hi @wvmoreira, the message above (here #4 (comment)) remains the best course of action

@wvmoreira
Copy link

Hello @gwlove
Are you all right?
Could you tell me if you still have plans to upgrade to version 4 of Glide?

@gwlove
Copy link
Member

gwlove commented Jun 1, 2020

Hello @wvmoreira! No changes from the last comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants