New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product Engineering Review: Generative_Question_Answering_Python #581

Open

chetan-hirapara opened this issue Apr 8, 2024 · 0 comments

Assignees

Labels

Collaborator

chetan-hirapara commented Apr 8, 2024 •

edited

Reviewer 1 comments:

section 3.1 converts tdml df to pandas df just to print in sorted order.
Link section to teradataml points to older teradataml version on docs.teradata
-Output of all cells is missing.

Reviewer 1 suggestions:

In section 3.1, no need to convert to pandas df. directly use sort() method of teradataml df
Update the links from older doc to new one: https://docs.teradata.com/r/Enterprise_IntelliFlex_VMware/Teradata-Package-for-Python-User-Guide-17.20
Recompile notebook to verify generated SQL queries.

Reviewer 2 comments:

use of to_pandas() should be avoided.
Fix the link to latest teradataml guide

Reviewer 2 suggestions:

use of to_pandas() should be avoided.
Fix the link to latest teradataml guide

PR# #604

chetan-hirapara self-assigned this

chetan-hirapara added the enhancement label

chetan-hirapara mentioned this issue

removed pandas and updated docs links #604

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment