Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Engineering Review: Remaining_Useful_Life_Forecasting_PY_SQL #586

Open
chetan-hirapara opened this issue Apr 8, 2024 · 0 comments
Assignees
Labels
enhancement Adding graphs and improving output

Comments

@chetan-hirapara
Copy link
Collaborator

Reviewer 1 comments:

  • Use teradataml API’s as much as possible instead of queries.
  • to_pandas() pull the data to client. Do not use it unless it is really required.

Reviewer 1 suggestions:

  • use df.group_by instead of query and use avg and count functions.
  • teradataml supports function corr use the same instead of pandas.corr.
  • use teradataml TDDecisionForest, TDDecisionForestPredict function instead of query.
  • teradataml supports in-house visualisation. Use teradataml DataFrame.plot instead of pandas/matplotlib plotting.

Reviewer 2 comments:

  • use of sql queries can be avoided at many places.

Reviewer 1 suggestions:

  • we have evaluate method instead of RegressionEvaluator in latest teradataml versions we can use that.
@chetan-hirapara chetan-hirapara added the enhancement Adding graphs and improving output label Apr 8, 2024
@chetan-hirapara chetan-hirapara self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding graphs and improving output
Projects
None yet
Development

No branches or pull requests

1 participant