Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suspicious typing error in pretty.py #2625

Closed
ksun212 opened this issue Nov 1, 2022 · 3 comments
Closed

A suspicious typing error in pretty.py #2625

ksun212 opened this issue Nov 1, 2022 · 3 comments

Comments

@ksun212
Copy link
Contributor

ksun212 commented Nov 1, 2022

Hello, the dataclass "Node" inside pretty.py has a field "key_separator" untyped, which makes this field actually a class attribute. I think this is uncommon for a dataclass. Is this field deliberately kept untyped, or simply a coding error?

Thanks in advance!

@willmcgugan
Copy link
Collaborator

It probably should be typed. Although coincedantaly it has still having the desired effect. Would you like to PR?

@ksun212
Copy link
Contributor Author

ksun212 commented Nov 13, 2022

It probably should be typed. Although coincedantaly it has still having the desired effect. Would you like to PR?

Sure, I created a PR.

@github-actions
Copy link

I hope we solved your problem.

If you like using Rich, you might also enjoy Textual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants