Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style variations to the progress bar widget #2920

Open
rodrigogiraoserrao opened this issue Jul 11, 2023 · 2 comments · May be fixed by #3143
Open

Add style variations to the progress bar widget #2920

rodrigogiraoserrao opened this issue Jul 11, 2023 · 2 comments · May be fixed by #3143
Assignees
Labels
enhancement New feature or request

Comments

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented Jul 11, 2023

(This issue is reserved for the EuroPython 2023 sprint. If you are not participating in the sprint, please refrain from working on this issue. Thanks!)

Currently, the ProgressBar widget can have its colours changed, but the bar style is always the same.
This issue concerns itself with adding style variations to the actual bar.
Add the following styles:

  • default (the current one)
  • thick (use taller block characters)
  • and any other(s) you can think of!

To change the style of the progress bar, you will need to change the characters that are used inside textual.renderables.bar.py::Bar.__rich_console__.

The style for the progress bar can be selected via a keyword-only parameter variant upon instantiation, like ProgressBar(variant="thick"), akin to Button.
The progress bar variant should also be exposed as a reactive attribute variant.

Good luck and have fun!

@petertalaber
Copy link

Hi, I have started to work on this issue in EuroPython Sprint.

@rodrigogiraoserrao
Copy link
Contributor Author

Hi, I have started to work on this issue in EuroPython Sprint.

Good luck; I'll be around to help.

@petertalaber petertalaber linked a pull request Aug 22, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants