Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog widget #3975

Open
willmcgugan opened this issue Jan 8, 2024 · 4 comments · May be fixed by #4044
Open

Dialog widget #3975

willmcgugan opened this issue Jan 8, 2024 · 4 comments · May be fixed by #4044
Assignees

Comments

@willmcgugan
Copy link
Collaborator

willmcgugan commented Jan 8, 2024

Build a generic dialog widget.

This widget will essentially be a container, which composes a dialog with standard styling.

I think it should work something along these lines:

from textual.widgets import Dialog

def compose(self) -> ComposeResult:
    with Dialog(title="Text"):
        yield Label("Do you like Textual?")
        with Dialog.Buttons():
            yield Button("Yes", id="yes")
            yield Button("No", id="no")

Dialog.Buttons would be a container which docs to the bottom of the dialog, and aligns its contents to the right.

Discuss API with @willmcgugan

@davep May be able to offer suggestions about styling the dialog.

10h

@willmcgugan
Copy link
Collaborator Author

image

@willmcgugan
Copy link
Collaborator Author

@davep Estimates please.

@davep
Copy link
Collaborator

davep commented Jan 17, 2024

There's been one in the description since you asked this morning.

@willmcgugan
Copy link
Collaborator Author

Please add them to the comments if you have updates. Suggest half days rather than hours. Hours seems a bit too granular.

@davep davep linked a pull request Jan 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants