Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap overloads with if TYPE_CHECKING #4431

Open
willmcgugan opened this issue Apr 19, 2024 · 2 comments
Open

Wrap overloads with if TYPE_CHECKING #4431

willmcgugan opened this issue Apr 19, 2024 · 2 comments
Assignees
@bswck
Labels
Task

Comments

@willmcgugan
Copy link
Collaborator

The @overload decorator incurs a small performance penalty.

If we wrap overloaded methods with if TYPE_CHECKING we can save a little import time.

Pointed out by @bswck willmcgugan/declare#3
@bswck
Copy link

bswck commented Apr 19, 2024

Feel free to assign me! I'll be happy to help.

@willmcgugan
Copy link
Collaborator Author

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bswck bswck

Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willmcgugan @bswck