Allow more easily customisable scrollbar glyphs #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I try to avoid Windows if I can help it, but unlike classic conhost I think the Windows Terminal has font fallback. That's not any criticism of this PR and you're probably already aware, but just thought I should mention it as there's likely some other glyphs used in Textual which are missing in Consolas. |
|
Yes, I personally use Windows Terminal with a nerd font, so textual apps look great on my machine. However, I often give TUI tools to people without python, so I compile them to an .exe with pyinstaller. Double clicking that will always open in cmd.exe, and the default font is Consolas. |
willmcgugan
requested changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4500
This allows a user to easily customise scrollbar display. For example, when using the Consolas font, scrollbars display poorly:
By reducing the characters to those supported, the display is more consistent:
By using some lightly shaded characters, the scrollbars gain some flair:
The blank glyph can also be replaced:
This is easier than replacing the entire
ScrollBarRender.render_barfunction.