Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyInstaller.sh touches system files #4923

Open
povik opened this issue Apr 8, 2024 · 1 comment
Open

DependencyInstaller.sh touches system files #4923

povik opened this issue Apr 8, 2024 · 1 comment
Assignees

Comments

@povik
Copy link
Contributor

povik commented Apr 8, 2024

Describe the bug

On Ubuntu, DependencyInstaller.sh seems to touch files installed by the system's package manager, even if you go the recommended route of setup.sh from OpenROAD-flow-scripts for a local install. I think it's reasonable to expect any dependency installer script to not do things like that.

Expected Behavior

.

Environment

N/A

To Reproduce

Look into https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/etc/DependencyInstaller.sh#L292 where it stands:

# need the strip "hack" above to run on docker
strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so

This runs for any Ubuntu installs, even local ones. This seems to be run from OpenROAD-flow-scripts/setup.sh too.

Relevant log output

No response

Screenshots

No response

Additional Context

No response

@vvbandeira
Copy link
Member

@habibayassin, could you move this strip command inside the Dockerfile/DockerHelper and make it conditional to run only on Ubuntu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants