Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle 8 compatibility #2

Closed
TheMrMilchmann opened this issue Feb 24, 2023 · 2 comments
Closed

Gradle 8 compatibility #2

TheMrMilchmann opened this issue Feb 24, 2023 · 2 comments
Assignees
@TheMrMilchmann
Labels
a:feature New feature or request
Milestone
0.3.0

Comments

@TheMrMilchmann
Copy link
Owner

Sigh. Another Gradle 8 migration that will not be straightforward. The option to pass env will probably have to be removed because toolchain tools can longer be null. Unfortunately, this also means that the calculation for tool defaults has changed unexpectedly (which, in turn, leads to issue with how we configure the tools).
@TheMrMilchmann TheMrMilchmann self-assigned this Feb 24, 2023
@TheMrMilchmann
Copy link
Owner Author

The tests fail on Gradle 8.0 and 8.0.1 in two situations:

  1. If env is passed as value.
  2. If no value is passed and no project-wide default toolchain is configured.

In both cases, the provider used to configure the toolchain tool has no value. The failures are caused by a semi-documented breaking change in Gradle 8. Since there was no previous warning for this behavior and no alternative is available, I've filed gradle/gradle#24055.

@TheMrMilchmann TheMrMilchmann added the a:feature New feature or request label Feb 28, 2023
@TheMrMilchmann TheMrMilchmann added this to the 0.3.0 milestone Feb 28, 2023
@TheMrMilchmann
Copy link
Owner Author

Fixed by c2c6fa9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheMrMilchmann TheMrMilchmann

Labels
a:feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@TheMrMilchmann