-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug - 04_removeFromArray: missing test case #271
Comments
@Sarthak-Malla would you still be interested in working on this? |
Hey, i would love to. How should I proceed? |
@Sarthak-Malla We'd need a new test added to both the test.skip('removes all instances of a value', () => {
expect(removeFromArray([1, 2, 2, 3], 2)).toEqual([1, 3]);
}); Or however you think makes sense to write the test. |
@Sarthak-Malla just checking in on the status of this |
@thatblindgeye Hey, I am really sorry. I am caught in load of work, is it possible to re-assign this to someone else? |
hey, |
Looks like such a test case was added after this issue was created. Closing this out, but thank you for bringing this up! |
@shubhatRashid it doesn't have the label, but #255 might actually be a decent first issue if you'd wanna check that out? |
Complete the following REQUIRED checkboxes:
Bug - location of bug: brief description of bug
format, e.g.Bug - Exercises: File type incorrect for all test files
The following checkbox is OPTIONAL:
1. Description of the Bug:
The testing for the solution has a missing test case that looks into if all the elements in the Array that matches the element to be deleted is properly deleted.
In other words, the Array from which the elements are supposed to be deleted from has no repeating values. So, the test case does not directly prompt the user to write code that deletes all the instances of the element that is supposed to be deleted from the Array.
2. How To Reproduce:
3. Expected Behavior:
If the code written does not account for repeated values like the one below, the modified test case (5th test case) results to a failure.
Note: Line 9 is commented such that the test case is not matched!
4. Desktop/Device:
5. Additional Information:
The text was updated successfully, but these errors were encountered: